Skip to content

Conversation

@NalinDalal
Copy link

@NalinDalal NalinDalal commented Jan 28, 2026

Fixes #3828

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

@welcome
Copy link

welcome bot commented Jan 28, 2026

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@release-com
Copy link

release-com bot commented Jan 28, 2026

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-d37c3856c3

@ksen0
Copy link
Member

ksen0 commented Jan 29, 2026

Hi @raclim , this PR is based on https://github.com/processing/p5.js-web-editor/blob/develop/contributor_docs/pr05_2025_typescript_migration/index.md#configuration-summary (@NalinDalal noted in Discord). I wasn't sure if this was ready for work, or blocked, or if there was an issue. Thanks for checking it out when you can.

@raclim
Copy link
Collaborator

raclim commented Jan 29, 2026

Thanks for flagging this @ksen0 and for trying this out @NalinDalal!

Before opening a pull request, we generally advise contributors to make sure that their work is associated with an open issue to avoid any potential extra work or miscommunication in expectations! You can read up more about it in our Preparing a Pull Request documentation or our overall Contributor Docs. For the TypeScript Migration, we've mostly been opening smaller issues/PRs to work incrementally, though we should probably be opening a general issue/sub-issues for better tracking.

For now, would you be able to create an issue for this that briefly summarizes your proposed changes and attach it to this PR? In the meantime, I'll take a look over this PR and try to make a larger issue/update the docs for folks to reference for migration work!

@NalinDalal NalinDalal changed the title client/modules/Preview: migrate to TypeScript, no-verify client/modules/Preview: migrate to TypeScript, no-verify Jan 30, 2026
@NalinDalal
Copy link
Author

Thanks for flagging this @ksen0 and for trying this out @NalinDalal!

Before opening a pull request, we generally advise contributors to make sure that their work is associated with an open issue to avoid any potential extra work or miscommunication in expectations! You can read up more about it in our Preparing a Pull Request documentation or our overall Contributor Docs. For the TypeScript Migration, we've mostly been opening smaller issues/PRs to work incrementally, though we should probably be opening a general issue/sub-issues for better tracking.

For now, would you be able to create an issue for this that briefly summarizes your proposed changes and attach it to this PR? In the meantime, I'll take a look over this PR and try to make a larger issue/update the docs for folks to reference for migration work!

bit late, but i have created the corresponding issue for same, check it out here

@raclim
Copy link
Collaborator

raclim commented Feb 3, 2026

Thanks so much @NalinDalal for attaching the issue! Tagging @clairep94 as well, who led a lot of the initial momentum for the TypeScript Migration, but I'll try to follow up by later this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript migration: client/modules/Preview

3 participants