-
Notifications
You must be signed in to change notification settings - Fork 212
i18n: fix example category translations across languages #1090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
i18n: fix example category translations across languages #1090
Conversation
|
Hi @limzykenneth 👋 |
|
Some questions. What is the source of the translation? Especially for the updates? What is your understanding of the original issue? |
|
Hi @limzykenneth, thanks for taking a look and for the questions — happy to clarify! Source of the translations : About the updates My understanding of the original issue (#283) If you’d prefer a different translation style or have a recommended source/guide for localization in this project, I’d be very happy to align with it and update the PR accordingly. Thanks again for your time and guidance! |
|
The reason I'm asking is that there are many translation changes that are not missing originally but they are changed, which is not what the original issue is about. Some of these translation changes also does not make sense since they don't change the meaning at all. I'm also not happy to accept any machine translation without native language user's input. |
|
Hi @limzykenneth, thank you for clarifying — I appreciate you pointing this out. You’re absolutely right about the scope. My intent was to ensure consistency across locales, but I understand now that this went beyond the original goal of addressing missing category keys only. I can revise this PR to: For the translated labels I added, I agree that native-language validation is important. If you’d prefer, I can either remove those or flag them for review by native contributors instead of including them here. Please let me know which direction you’d prefer, and I’ll update the PR accordingly. Thanks for taking the time to review and guide me on this . |





Summary
Fixes missing and inconsistent translations for Example Categories across multiple languages.
What was changed
Verification
fixes issue #283