Fix chainable p5 instance methods returning void instead of p5#8426
Open
guan404ming wants to merge 1 commit intoprocessing:dev-2.0from
Open
Fix chainable p5 instance methods returning void instead of p5#8426guan404ming wants to merge 1 commit intoprocessing:dev-2.0from
guan404ming wants to merge 1 commit intoprocessing:dev-2.0from
Conversation
8781e22 to
e0f5901
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8415
Changes:
Previously, chainable methods on the main p5 class (like background(), stroke(), fill(), translate(), etc.) were typed to return void instead of p5 in the generated TypeScript definitions. This was due to an explicit exclusion condition
options.currentClass !== 'p5'in the type generation logic.Screenshots of the change:
PR Checklist
npm run lintpasses