-
-
Notifications
You must be signed in to change notification settings - Fork 128
Publish org.processing.core.pdf to maven Central
#1407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@Stefterv hey started with PDF since it was the easiest. |
org.processing.core.pdf to maven Central
|
Thanks @avinxshKD I added a few comments ;) |
sure was already on it thanks and welcome :) |
dd75209 to
c8b553d
Compare
|
@Stefterv Updated the coordinates and removed the signing checkk. and |
|
Ready for another look. |
|
The coordinates still need to be fixed, the version should be equal to the processing version, not the version from the library.properties |
c8b553d to
714f11e
Compare
|
@Stefterv hve updated the version to use rootProject.version so it matches the Processing version as requested |
|
Hi @avinxshKD, it appears to me that you are overly relying on AI for making your changes, please take a look at the "General note about github comments, reviews, and PRs" section of this message. |
714f11e to
dbf8486
Compare
dbf8486 to
6772f84
Compare
|
@Stefterv so sorry. Been swamped with exams lately,will be more careful reviewing before pushing. |
|
No worries @avinxshKD thank you for the changes they look great 💙 |
Adds Maven Central publishing configuration to the PDF library.
Part of #1403