-
Notifications
You must be signed in to change notification settings - Fork 228
Publish /en/lessons/designing-database-nodegoat #3706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
Upload en-tr figures.
Create Markdown file for new EN translation.
Remove errant -, line 8
Minor copyedits.
Minor edits to figure captions.
|
Hello Alex @hawc2 and Laura @lachapot, I’ve staged designing-database-nodegoat for publication. As discussed, I've also read the lesson again myself, applying some small final copyedits 91442ff as well as some minor adjustments to the Figure captions 8fd008b. Please read it through in Preview and let me know if you notice anything further which you'd like to adjust. Thank you ✨ |
|
@anisa-hawes looks good to go to me |
|
Hello Alex @hawc2 and Anisa @anisa-hawes ! Thank you very much, Anisa, for finalizing the nodegoat translation! The only thing I spotted is that some of the figure titles in the second part of the lesson still have “our”/“us” rather than “you” (sorry I didn’t catch those when I was editing in the previous round!). Here are the figure titles that might need tweaking: Figure 3: The empty nodegoat workspace before creating your project Figure 4: The Model tab and the Add Object Type option allow you to define your data model. Figure 12: Visualization of the data model Figure 16: the authors in the database Figure 17: Overview of the authors in the database, …. I wasn’t sure whether you’d prefer me to edit the Markdown directly at this stage, but I’m very happy to do so if that’s easier, just let me know. Otherwise, it looks great to me! |
Minor edits to figure captions.
Revise handling of quotation, line 47.
Preparing files for publication.
Closes #3705
Checklist
Closes #ISSUENUMBERto your summary above[ ] if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.