CI: overhaul packaging workflow and mobile release options#677
CI: overhaul packaging workflow and mobile release options#677tyreseluo wants to merge 2 commits intoproject-robius:mainfrom
Conversation
- add per-platform inputs and build matrices - create release once and upload assets via releaseId - add Android/iOS packaging with TestFlight envs - set macOS signing_identity placeholder
kevinaboos
left a comment
kevinaboos
left a comment
There was a problem hiding this comment.
Thanks Tyrese, I appreciate the overhaul of our packaging logic here.
I have one general concern: the code in release.yml is now a lot harder to read (and most importantly, harder for myself and others to maintain) due to lots of custom actions and python scripts interspersed throughout it. When I glance at the code, I cannot clearly understand what it's doing any more.
The older code was quite a bit easier to understand. Similarly, moly-ai's release.yml file is also easy to read — is there any reason why we wouldn't just copy that?
I'm a bit wary of bringing in a dependency on your new makepad-packaging-action since we (the project-robius org) do not have control over that nor the ability to modify it. If you insist on using that, I'd have to do a full audit of that as well. If you'd like to transfer it to the main project-robius org, that would make it easier for us to rely on it (of course you can maintain full ownership rights of it).
| build_android: | ||
| description: 'Build Android APK' |
There was a problem hiding this comment.
i assume this is Android on aarch64? (Android can also run on x86_64, so please be specific here)
| import os | ||
| from pathlib import Path | ||
|
|
||
| def truthy(value: str) -> bool: |
There was a problem hiding this comment.
truthy is a confusing name, do you mean something like "is_true"?
kevinaboos
added
waiting-on-author
2 participants
PR Content
Use makepad-packaging-action to streamline the current makepad release CI workflow for easier centralized management.