Porting essential blacklight range limit functionality#3098
Open
cgalarza wants to merge 6 commits intoprojectblacklight:mainfrom
Open
Porting essential blacklight range limit functionality#3098cgalarza wants to merge 6 commits intoprojectblacklight:mainfrom
cgalarza wants to merge 6 commits intoprojectblacklight:mainfrom
Conversation
…e blacklight_range_limit.
… from facet label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, I'd like to acknowledge all the work that people have put in the blacklight-range-limit plugin over the years. Without their effort I would not be submitting this PR today. Thank you! I hope that this new (potential) iteration allows for better support of this functionality.
The goal of this pull request is to port the essential functionality of the blacklight-range-limit plugin into blacklight core. This includes the form that allows a user to enter two years within a facet and excludes the histogram (and the associated functionality). Notably, this MR does not include any javascript.
Currently, the blacklight-range-limit plugin is not compatible with Blacklight 8. We are hoping that this port allows us to update our applications to Blacklight 8 while maintaining the core functionality provided by the blacklight-range-limit plugin.
Some notes:
Some potential additional features:
statscomponent. I wasn't sure how folks would feel about that, but depending on community feedback it's something that can be added in later.My time is limited over the next few weeks. I will try to respond and help as much as possible, but would welcome the community's help in finishing this work.