Skip to content

introduce default http response option default-http-response, dhr#1142

Merged
dogancanbakir merged 8 commits intodevfrom
fix_hi_response
Jan 12, 2026
Merged

introduce default http response option default-http-response, dhr#1142
dogancanbakir merged 8 commits intodevfrom
fix_hi_response

Conversation

@dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir commented Apr 1, 2025

No description provided.

@dogancanbakir dogancanbakir requested a review from ehsandeep April 1, 2025 12:12
@dogancanbakir dogancanbakir self-assigned this Apr 1, 2025
@ehsandeep ehsandeep linked an issue Apr 1, 2025 that may be closed by this pull request
http-index only serves the custom index file for the root path #1141
Closed
@ehsandeep ehsandeep changed the base branch from main to dev April 1, 2025 18:44
ehsandeep
ehsandeep requested changes Apr 1, 2025
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks -http-directory and -dynamic-resp option, we need to ensure both options works as expected along with this change.

ehsandeep
ehsandeep requested changes Jul 9, 2025
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict

@dogancanbakir dogancanbakir requested a review from ehsandeep July 12, 2025 05:36
Mzack9999
Mzack9999 requested changes Sep 10, 2025
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation breaks the existing reflection functionality, ex:

$ curl "http://localhost/aaa" -H "Host: a.d30rdlnirrqmn1ona83gius5yy3yfsjkd.127.0.0.1"
<html><head></head><body>dkjsfy3yy5suig38ano1nmqrrinldr03d</body></html>%

Maybe we should introduce another flag that takes priority over other flags (something like -default-file)? What do you think?

@coderabbitai
Copy link

coderabbitai bot commented Jan 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@dogancanbakir dogancanbakir mentioned this pull request Jan 3, 2026
Closed
@dogancanbakir dogancanbakir changed the title fix -hiresponse introduce default http response option -dhr Jan 3, 2026
@dogancanbakir dogancanbakir changed the title introduce default http response option -dhr introduce default http response option default-http-response, dhr Jan 3, 2026
Mzack9999
Mzack9999 requested changes Jan 5, 2026
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - let's update docs!

@dogancanbakir dogancanbakir merged commit 60285b0 into dev Jan 12, 2026
9 checks passed
@dogancanbakir dogancanbakir deleted the fix_hi_response branch January 12, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@ehsandeep ehsandeep Awaiting requested review from ehsandeep

Assignees

@dogancanbakir dogancanbakir

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

http-index only serves the custom index file for the root path

3 participants

@dogancanbakir @ehsandeep @Mzack9999