Conversation
Signed-off-by: Dwi Siswanto <git@dw1.io>
string accessors. Replaces unsafe zero-copy `conversion.String()` with `bytes.Buffer.String()` in `HeadersString()` and `BodyString()` methods. The previous (>= v0.7.0) implementation used `conversion.String()` on the buffer's byte slice, which created a string that shared memory with the pooled `bytes.Buffer`. When buffers were returned to the pool (via `Close()`) and reused, the strings held by consumers would be corrupted lmao. Signed-off-by: Dwi Siswanto <git@dw1.io>
dwisiswant0
commented
Nov 29, 2025
Comment on lines
317
to
321
| // FullResponseString returns the current response as string in the chain. | ||
| // | ||
| // The returned string is a copy and remains valid even after Close() is called. | ||
| // This is a zero-copy operation from the byte slice. | ||
| func (r *ResponseChain) FullResponseString() string { | ||
| return conversion.String(r.FullResponseBytes()) |
Member
Author
There was a problem hiding this comment.
FullResponseString() is already safe because FullResponseBytes() returns a new slice, so I will leave it as is to maintain the zero-copy optimization on that specific method (avoiding a second copy).
Mzack9999
approved these changes
Nov 30, 2025
Mzack9999
deleted the
dwisiswant0/fix/httputil/prevent-memory-corruption-in-ResponseChain
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
fix(httputil): prevent memory corruption in
ResponseChainstring accessors.
Replaces unsafe zero-copy
conversion.String()with
bytes.Buffer.String()inHeadersString()and
BodyString()methods.The previous (>= v0.7.0) implementation used
conversion.String()on the buffer's byte slice,which created a string that shared memory with the
pooled
bytes.Buffer. When buffers were returnedto the pool (via
Close()) and reused, thestrings held by consumers would be corrupted lmao.
Proof
patch:
main: