Skip to content

(bug) Ignore not existing cluster errors #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianlucam76 merged 1 commit into from
Oct 16, 2025
Merged

(bug) Ignore not existing cluster errors #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions controllers/classifier_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,10 @@ func (r *ClassifierReconciler) updateLabelsOnMatchingClusters(ctx context.Contex
l.V(logs.LogDebug).Info("update labels on cluster")
err = r.updateLabelsOnCluster(ctx, classifierScope, cluster, clusterproxy.GetClusterType(ref), l)
if err != nil {
// If cluster was removed before classifier had a chance to react to it, ignore the error
if apierrors.IsNotFound(err) {
return nil
}
l.V(logs.LogDebug).Error(err, "failed to update labels on cluster")
return err
}
Expand Down
4 changes: 2 additions & 2 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,10 @@ func main() {
pflag.CommandLine.AddGoFlagSet(flag.CommandLine)
pflag.Parse()

reportMode = controllers.ReportMode(tmpReportMode)

ctrl.SetLogger(klog.Background())

reportMode = controllers.ReportMode(tmpReportMode)

ctrlOptions := ctrl.Options{
Scheme: scheme,
Metrics: getDiagnosticsOptions(),
Expand Down