-
Notifications
You must be signed in to change notification settings - Fork 2.4k
config: add global mattermost_api_url and mattermost_api_url_file #4917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Default Mattermost receiver webhook_url/webhook_url_file from global settings Signed-off-by: Kliachin Aleksei <madest92@gmail.com>
55bfcc5 to
6b0006e
Compare
|
Since #4812 was merged could you please try to follow it's pattern where possible? |
I've reviewed the changes. This doesn't apply to mattermost_api_url/mattermost_api_url_file. Conflict fixed. |
|
@TheMeier Now you need to write like this: Instead of What do you think about this? I can submit changes as part of this merge request, or create a new one once the current one is accepted. |
|
I personally think this should be two separate changes. Adding something is a completly different beast than breaking changes. |
|
Okay, then I'm waiting for the current changes to be accepted. |
|
@TheMeier hi Do you have any comments on Mr? |
Default Mattermost receiver webhook_url/webhook_url_file from global settings