Open
Conversation
Signed-off-by: kairvee <145572028+kairveeehh@users.noreply.github.com>
Author
|
@ArthurSens kindly review it. |
jan--f
requested changes
Feb 3, 2026
Contributor
jan--f
left a comment
jan--f
left a comment
There was a problem hiding this comment.
Hi, thanks a lot!
I have two requests:
- Can you add a Makefile target that runs mdox and change the action to use that new target?
- I don't think we need to report uploaded anywhere. It would be better to fail the run when broken links are detected. We can then run the check locally and deal with broken links in a PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #2794
@ArthurSens , it checks and lets you have an artifact after it runs , scheduled weekly and I have tested manually as well.
There are certain cases where you might want to ignore the fact that the link is broken but those are very specific to be added inside the rules for the CI , kindly review and let me know if anything is to be modified.