default should no carry a title: because it overwrites...#17
Open
rdymac wants to merge 1 commit intoprose:gh-pagesfrom
Open
default should no carry a title: because it overwrites...#17rdymac wants to merge 1 commit intoprose:gh-pagesfrom
rdymac wants to merge 1 commit intoprose:gh-pagesfrom
Conversation
default should no carry a title: because it overwrites the ```<title>``` tag and makes it static instead of change it based in the current page title. Beside having 2 ```<h1>``` elements in the same page, the website title or logo should be a static content, not based in the variable of the current page
Author
|
Home could carry a static page with its own title This is basic semantics and search engine optimization, as the blog post title is the most important part of the post content it should be a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default should no carry a title: because it overwrites the
<title>tag and makes it static instead of change it based in the current page title.Besides having 2
<h1>elements in the same page, the website title or logo should be a static content, not based in the variable of the current page