Support more chars in type URLs in the C++ text-format parser. #25665
+510
−322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the C++ text-format parser to allow for more characters and formats in the type URL prefixes of expanded Any protos. This follows a recent change to the text-format spec which we are now closely following [1,2]. Note: This change modifies the default implementation of the `Finder` interface by removing [this special treatment](https://github.com/protocolbuffers/protobuf/blob/135bec4ee8c7cb8f9f8f2d5723bda5005948fa69/src/google/protobuf/text_format.cc#L255-L258) of non-standard type URLs. Any protos with type URL prefixes that are not `type.googleapis.com/` or `type.googleprod.com/` won't be treated specially anymore when converting to or from textproto using the default settings (for example, when using `TextFormat::PrintToString()` or `TextFormat::ParseFromString()`). In particular, Any protos with a non-standard type URL prefix will now get expanded by default when printed to textproto with the [`SetExpandAny()`](https://github.com/protocolbuffers/protobuf/blob/135bec4ee8c7cb8f9f8f2d5723bda5005948fa69/src/google/protobuf/text_format.h#L406) option enabled. Refs: - [1] https://protobuf.dev/reference/protobuf/textformat-spec/#characters - [2] https://protobuf.dev/reference/protobuf/textformat-spec/#field- PiperOrigin-RevId: 844790397
copybara-service
bot
force-pushed
the
test_844790397
branch
from
ad3c8c2 to
19ac33b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support more chars in type URLs in the C++ text-format parser.
Change the C++ text-format parser to allow for more characters and formats
in the type URL prefixes of expanded Any protos. This follows a recent
change to the text-format spec which we are now closely following [1,2].
Note: This change modifies the default implementation of the
Finderinterface by removing this special treatment of non-standard type URLs. Any protos with type URL prefixes that are nottype.googleapis.com/ortype.googleprod.com/won't be treated specially anymore when converting to or from textproto using the default settings (for example, when usingTextFormat::PrintToString()orTextFormat::ParseFromString()). In particular, Any protos with a non-standard type URL prefix will now get expanded by default when printed to textproto with theSetExpandAny()option enabled.Refs: