Remove direct dependency on rules_apple#25708
Open
keith wants to merge 1 commit intoprotocolbuffers:mainfrom
Open
Remove direct dependency on rules_apple#25708keith wants to merge 1 commit intoprotocolbuffers:mainfrom
keith wants to merge 1 commit intoprotocolbuffers:mainfrom
Conversation
JasonLunn
added
mac
bazel
🅰️ safe for tests
This was only used for 2 apple_binary targets that we can replace with cc_binary. There is a difference here that previously these binary targets would transitively set the macOS version being targeted via a transition, this is no longer the case and now that setting is inherited from the including project's config instead. If unset it uses the host OS version which isn't ideal.
JasonLunn
force-pushed
the
ks/remove-direct-dependency-on-rules_apple
branch
from
f637c74 to
08492f7
Compare
JasonLunn
added
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
JasonLunn
requested review from
a team and
dmaclach
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was only used for 2 apple_binary targets that we can replace with
cc_binary. There is a difference here that previously these binary
targets would transitively set the macOS version being targeted via a
transition, this is no longer the case and now that setting is inherited
from the including project's config instead. If unset it uses the host
OS version which isn't ideal.