Open
Conversation
5cca1a8 to
5ae3270
Compare
a781a10 to
4a62c2e
Compare
Signed-off-by: Matt Leon <mattleon@google.com>
* Also ran `perl -pi -e 's/rust_library/rust_static_library/g' bazel/cargo/wasmtime/remote/BUILD.wasmtime-c-api-impl-*.bazel` Signed-off-by: Matt Leon <mattleon@google.com>
4a62c2e to
439762d
Compare
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes: https://github.com/bytecodealliance/wasmtime/releases/tag/v39.0.1
The original goal:
wasmtime compile).In order to make the resource limiting changes, I needed to use the wasmtime C api rather than the wasm-c-api. I migrated the wasmtime implementation to use the C++ API and migrated the C-api to use the prefixed version by default (required to use the C++ API).
Other yak shaving changes required to make this change: