Open
Conversation
65653e0 to
e389390
Compare
16c6607 to
60e568d
Compare
b6eaf80 to
1e4d268
Compare
for more information, see https://pre-commit.ci
|
diff-shades results comparing this PR (5456363) to main (58f31a7). The full diff is available in the logs under the "Generate HTML diff report" step. |
Contributor
|
I would also like to see this with a configurable set of additional "pragma" comments. Eg, Fixit uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pragma comments have similar semantics as
# type: ignore, so they should be treated similarly: lines marked with them are fine to merge (this generally extends the scope of the suppression/pragma) but not OK to split.Note: this changes the stable style; I'm not sure if that's OK in this case or not, but happy to rework this under a preview style flag if that's the only concern.
Checklist - did you ...
CHANGES.mdif necessary?