fix: preserve custom CookiePolicy in Session.prepare_request#7123
Open
shindonghwi wants to merge 1 commit intopsf:mainfrom
Open
fix: preserve custom CookiePolicy in Session.prepare_request#7123shindonghwi wants to merge 1 commit intopsf:mainfrom
shindonghwi wants to merge 1 commit intopsf:mainfrom
Conversation
b6bf410 to
12502bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using a custom
CookiePolicyon a session'sCookieJar, the policy was being discarded whenSession.prepare_request()was called. This happened because the code was creating a newRequestsCookieJar()with the default policy instead of copying the session's jar with its policy preserved.This fix uses the existing
_copy_cookie_jar()function to properly preserve theCookiePolicywhen merging cookies.Related Issues
proposed/3.0.0branch in 2017)Changes
_copy_cookie_jarinsessions.py_copy_cookie_jar(self.cookies)instead ofmerge_cookies(RequestsCookieJar(), self.cookies)inprepare_request()test_cookie_policy_preserved_on_prepare_requestTest Plan