Update pool methods with docs and elegant syntax#1353
Open
complexsum wants to merge 3 commits intopsycopg:masterfrom
Open
Update pool methods with docs and elegant syntax#1353complexsum wants to merge 3 commits intopsycopg:masterfrom
complexsum wants to merge 3 commits intopsycopg:masterfrom
Conversation
Update documentation of __init__ method of ThreadedPoolConnection. The old documentation was incorrect because it says "initialze a threading lock."
Updated methods of the ThreadedConnectionPool class to use the elegant context manager syntax.
Member
|
What is the need of the elaborate docstring if it doesn't affect the docs at https://www.psycopg.org/docs/pool.html ? |
Author
|
@dvarrazzo I didn't knew about that but still it's good to have the docs updated in the code itself :) |
Member
|
It is unneeded repetition IMO, unless you format that docstring in Sphinx and have the docs autogenerated from it. Are you interested in this change? If not I will reject this as it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.