Skip to content
This repository was archived by the owner on Jan 30, 2026. It is now read-only.

Update/pubky specs2#1855

Open
flaviomoceri wants to merge 5 commits intodevfrom
update/pubky-specs2
Open

Update/pubky specs2#1855
flaviomoceri wants to merge 5 commits intodevfrom
update/pubky-specs2

Conversation

@flaviomoceri
Copy link
Contributor

No description provided.

@socket-security
Copy link

socket-security bot commented Aug 27, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedpubky-app-specs@​0.3.5 ⏵ 0.4.071 -5100100 +194 +5100

View full report

@flaviomoceri flaviomoceri marked this pull request as ready for review August 28, 2025 08:10
Copy link
Contributor

@tipogi tipogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀. Now we need to try the v4.0.0 and after merge it

@flaviomoceri
Copy link
Contributor Author

done @tipogi

@catch-21
Copy link
Collaborator

catch-21 commented Aug 28, 2025

didn't make use of setWasmError so I think we want to catch and set this error to display useful message to users when JIT is disabled etc, which would come from the builder?

@tipogi
Copy link
Contributor

tipogi commented Aug 29, 2025

Few questions:

  • Which is the origin of JIT errors? is it because wasm or another initialization error
  • Now if you do not have the instance of the PubkySpecsAppBuilder, you cannot create the objects

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants