test: use EphemeralTestnet singleton in nexus-watcher tests#671
Open
ok300 wants to merge 4 commits intopubky:mainfrom
Open
test: use EphemeralTestnet singleton in nexus-watcher tests#671ok300 wants to merge 4 commits intopubky:mainfrom
EphemeralTestnet singleton in nexus-watcher tests#671ok300 wants to merge 4 commits intopubky:mainfrom
Conversation
EphemeralTestnet in nexus-watcher testsEphemeralTestnet singleton in nexus-watcher tests
tipogi
approved these changes
Jan 19, 2026
SHAcollision
approved these changes
Jan 19, 2026
Collaborator
SHAcollision
left a comment
There was a problem hiding this comment.
IMO good to merge. But i thought it might be relevant to raise for you this Codex comment:
create_external_test_homeserver()depends on global initialization order
- The helper now errors if
SHARED_TESTNETis not initialized, which is correct but fragile. If any future test calls this helper without first going throughWatcherTest::setup(), it will return an error (SHARED_TESTNET not initialized) and fail unexpectedly.- Recommendation: either make
create_external_test_homeserver()lazily initialize the testnet, or document the required initialization order clearly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies test setup in the
nexus-watchersuite by only initializing the test stack and theEphemeralTestnetonce, then re-using them across thenexus-watchertests.