Transfer js code in listeners.html into separate .js file#1213
Open
Dalu46 wants to merge 3 commits intopubliclab:mainfrom
Open
Transfer js code in listeners.html into separate .js file#1213Dalu46 wants to merge 3 commits intopubliclab:mainfrom
Dalu46 wants to merge 3 commits intopubliclab:mainfrom
Conversation
|
Thanks for opening this pull request! |
5 tasks
TildaDares
approved these changes
Oct 25, 2022
Member
TildaDares
left a comment
There was a problem hiding this comment.
Amazing work @Dalu46. Thank you!!
Member
|
Hi @Dalu46, can you resolve the merge conflicts? Thanks! |
TildaDares
requested changes
Oct 25, 2022
| })(); | ||
| </script> | ||
| </html> | ||
| <div id="map" style="width:100%; height:100%; position:absolute; top:0;"></div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1184 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt testIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!