Freshen some dependencies and avoid warnings#65
Open
sampsyo wants to merge 2 commits intopulp-platform:masterfrom
Open
Freshen some dependencies and avoid warnings#65sampsyo wants to merge 2 commits intopulp-platform:masterfrom
sampsyo wants to merge 2 commits intopulp-platform:masterfrom
Conversation
Resolves this error when compiling with Rust 1.86.0: error[E0282]: type annotations needed for `Box<_>` --> [...]/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/time-0.3.30/src/format_description/parse/mod.rs:83:9 | 83 | let items = format_items | ^^^^^ ... 86 | Ok(items.into()) | ---- type must be known at this point | = note: this is an inference error on crate `time` caused by an API change in Rust 1.80.0; update `time` to version `>=0.3.35` by calling `cargo update`
It looks like the tarpaulin code coverage tool changed its recommendation for which attribute to use to exclude code from coverage tracking. Unfortunately, on stable Rust, this still requires excluding a lint rule: xd009642/tarpaulin#487
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Freshening the
timedependency avoids a Rust compiler error on 1.86 or greater. I also avoided some warning due to the tarpaulin attributes by (a) switching to the new recommended syntax for ignoring code coverage, and (b) following the compiler's (and documentation's) advice to suppress the resulting warning from that new syntax.