Open
Conversation
Smephite
force-pushed
the
fix/runtime_exit
branch
from
138a0ae to
0c819b2
Compare
Member
|
Hi @Smephite can you rebase on the current main? Afterwards, we will review it and merge it |
Fix runtime exit routine not recovering return address correctly
Use cluster local core ID for determining which core is to set EOC instead of global one. This fixes multi-cluster configurations not setting the EOC correctly on cluster != 0
Smephite
force-pushed
the
fix/runtime_exit
branch
from
0c819b2 to
ba86791
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix runtime exit routine not recovering return address correctly.
This bug applied only to core 0 of any cluster.
For the call to
snrt_set_eoc_and_return_code, the ra register was not saved, thus returning to an unexpected location after finishing_snrt_exit.