This repository was archived by the owner on Jun 10, 2022. It is now read-only.
Enhancement for guest orders, products, orders and purchase items#3
Open
herbyme wants to merge 7 commits intopunkstar:masterfrom
Open
Enhancement for guest orders, products, orders and purchase items#3herbyme wants to merge 7 commits intopunkstar:masterfrom
herbyme wants to merge 7 commits intopunkstar:masterfrom
Conversation
…or each customer.
Owner
There was a problem hiding this comment.
What happens here if you pass in --customers 50000 3 5?
Author
There was a problem hiding this comment.
I have made a fix to this to pick up items from the existing database. I'll submit a pull request once I have made the other changes.
Owner
|
Thanks for this! I've wanted to add this for ages. |
…of createFakeOrder() solely on createFakeProduct()
…ld be adjustable though.
Author
|
I have a new patch that fixes some of these issues and I'll submit it pending your suggestions/feedback. Thanks heaps. |
…n. Made other changes as well based on feedback.
… have an existing item in the catalog. This means you should be able to create 'simple' product type items on the fly with an empty catalog.
Author
|
I've added changes based on your review. Not sure if you want me to create a new branch and submit a new pull request or happy to use the 'new' commits on herbyme/magefaker? |
|
Hi guys, any news about this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1 and #2
Added options for guest orders, products, as well as orders for each fake customer. Didn't break it out into separate classes or separate commands (wanted to keep it as one command).