Conversation
Under the hood, a `concat` resource build a `file` resource with its content set to the concatenation of the contents of the corresponding `concat::fragment`. While each `concat::fragment` allow to pass value to its `content` parameter as a Sensitive, this information is not propagated to the built `file` resource, resulting in a diff being displayed when content of the file is updated. In order to avoid logging sesitive information, check if any of the fragments' content is sensitive, and if so make the content of the built file resource sensitive too.
smortex
requested review from
a team,
b4ldr,
bastelfreak and
ekohl
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under the hood, a
concatresource build afileresource with itscontent set to the concatenation of the contents of the corresponding
concat::fragment.While each
concat::fragmentallow to pass value to itscontentparameter as a Sensitive, this information is not propagated to the
built
fileresource, resulting in a diff being displayed when contentof the file is updated.
In order to avoid logging sesitive information, check if any of the
fragments' content is sensitive, and if so make the content of the built
file resource sensitive too.