(MODULES-11645) Ignore services with restart option as 'no' in exists? method #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…? method Services who have restart option set as 'no' are meant to be batch processing jobs which terminate once completed. Docker compose does not restart them, but in the exists? method, puppet looks for a running service. When it is unable to see a running service, it incorrectly assumes non-desired state and makes a corrective change. This commit rejects services with restart 'no' from the compose_services to mitigate this bug.
shubhamshinde360
force-pushed
the
MODULES-11645
branch
from
74bb531 to
dbf39d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Services who have restart option set as 'no' are meant to be batch processing jobs which terminate once completed. Docker compose does not restart them, but in the exists? method, puppet looks for a running service. When it is unable to see a running service, it incorrectly assumes non-desired state and makes a corrective change. This commit rejects services with restart 'no' from the compose_services to mitigate this bug.
Additional Context
Related Issues (if any)
Checklist
puppet apply)