Modernise, and incorporate improvements from localstack downstream#80
Open
Modernise, and incorporate improvements from localstack downstream#80
Conversation
2a6dcf6 to
840553e
Compare
840553e to
dede6bf
Compare
a9a0f23 to
da33e4a
Compare
976b466 to
8e84c19
Compare
94b1bec to
33ce10b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The downstream localstack fork contains a number of changes and improvements, while also breaking compatibility with velocity in favour of matching the behaviour of AWS' own fork of velocity used for templating in services like AppSync.
Additionally, the downstream fork adds golden testing against those AWS services to ensure compatibility.
The current intention of this PR is to attempt to:
The next current challenge is to backport enhanced assignment (e.g.
$foo[1].bar = 3) — downstream uses a concise but limited approach for this, and I believe there's a general solution lurking which would also allow direct support for the case that downstream'sREPLACE_FORMAL_TEXTtrick serves.