Skip to content

Conversation

@pusewicz
Copy link
Owner

No description provided.

Base automatically changed from cleanup-colors to main April 27, 2025 12:59
@pusewicz pusewicz requested a review from Copilot April 27, 2025 12:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request bumps the MRuby version to 3.4.0 and updates the naming conventions for color and pixel factory methods throughout the codebase. Key changes include:

  • Renaming of color factory functions (e.g., from rgb_f to cf_make_color_rgb_f) in both Ruby tests and C source files.
  • Removal of tests and implementations for color operations and color–pixel conversions.
  • Updating the Rakefile to reflect the new MRuby version and its extraction directory.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
test/color_test.rb Updated factory method names and removed tests for color operations.
src/color.c Renamed factory functions and removed color operation and conversion functions.
example/example.rb Introduced a new Circle class and updated app creation to use constants.
Rakefile Bumped MRuby version to 3.4.0 and adjusted dependency directory handling.
Comments suppressed due to low confidence (3)

test/color_test.rb:55

  • The removal of 'Cute::Color operations' tests may lead to missing coverage for color operations. Verify that these functionalities are intentionally deprecated or update the tests if the features are still supported.
end

Rakefile:36

  • Verify that MRuby 3.4.0 extracts to the correct directory without needing the mv command. If the archive extraction does not produce the expected directory structure, update the extraction steps accordingly.
sh "unzip -q #{MRUBY_ARCHIVE} -d #{DEPS_DIR}"

src/color.c:424

  • [nitpick] Since the factory methods have been renamed to use the 'cf_make_' prefix, consider removing or updating this TODO comment to reflect the completed change.
// TODO: Rename these to match CF

@pusewicz pusewicz merged commit f1e90be into main Apr 28, 2025
1 check passed
@pusewicz pusewicz deleted the pu-mruby-3-4 branch April 28, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant