Use ValueError instead of IndexError in _degrees_to_index #2648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@aman-coder03 the tests are failing, can you take a look? |
Contributor
Author
|
@kandersolar thanks for having a look |
|
Hi, I would like to contribute this |
Contributor
Author
|
@Pradeepbeleri hi, |
Contributor
Author
|
The remaining failures are due to deprecation tests: "the tested function is scheduled to be removed in 0.14”. |
aman-coder03
force-pushed
the
fix/degrees-to-index-valueerror
branch
from
550468f to
f13ae1a
Compare
Contributor
Author
|
@kandersolar all the tests are passing now. You can have a look now! |
cwhanse
approved these changes
Feb 4, 2026
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Contributor
Author
|
@cwhanse i have implemented the changes |
Member
Wrong PR for this comment, I think. |
Contributor
Author
|
@cwhanse i committed your suggestion (removing the pytest from line 3 as it is already present on line 9)😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Replaces
IndexErrorwithValueErrorin_degrees_to_indexfor invalidinput values.
This aligns the exception type with Python and NumPy conventions and
improves API correctness without changing behavior.
Fixes #2647