Conversation
Zathura sets a special adjust mode before showing the inputbar. Remaining in that mode after it has been hidden breaks things like rotation, so reset to none.
|
Woudn't it be nice to restore the adjust mode to the value before entering the inputbar? |
|
Yeah, I've thought of this too. This technically isn't a regression since the inputbar was leaving the adjust mode in a broken state before. I was under the impression that hiding the index did the same thing, but it actually only does it when the adjust mode was inputbar: Lines 1245 to 1248 in b794eb2 I guess this could be cleaned up, and the adjust mode can be restored. |
Exactly, this PR seemed to go in the direction of improving this behavior, hence my suggestion. |
sebastinas
left a comment
There was a problem hiding this comment.
Please implement the changes mentioned by @jdujava.
|
Sorry, I stopped using Zathura due to growing frustration with some less trivial bugs. I think it'd be best if someone else picked up this patch. |
Zathura sets a special adjust mode before showing the inputbar. Remaining in that mode after it has been hidden breaks things like rotation, so reset to none.