You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just a heads-up for @Lucas-C and @andersonhc and anyone else interested:
Converting table cells to text regions will make tables a lot more flexible and useful:
Freely format text within cells
Combine text and images in cells in arbitrary sequence
Allow to split cells for page breaks
But there's also stuff that needs to change in a backwards incompatible manner:
No "data driven" spans in the core library. Explicit colspan and rowspan arguments competing with "special content" in the actual cell data is bad design. It results in hard to predict behaviour and makes things unnecessarily complicated, because the code needs to rearrange the internal structure of the table in several iterations after the data has been collected. Besides, I thought there was consensus that any "data driven" formatting should be relegated to data adapters, and this functionality is trivial to implement that way.
Unfortunately, the original implementation declared line_height to be an absolute size in document units. With the possibility to arbitrarily change the font size within the text, this doesn't make any practical sense. Because of that, HTML defines line_height as a factor relative to the font height, and I've adapted the same strategy in the text regions. Tables should not be an exception here. This will most likely be the most annoying change for end users, but that can't be helped.
Maybe we should add notices to the documentation in advance, to give our users a chance to prepare for those changes.
This will solve an issue I'm having. Any idea when it will be merged?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a lot of stuff
Checklist:
meaning that both
pylint(static code analyzer) andblack(code formatter) are happy with the changes of this PR.docs/folderCHANGELOG.mdThis is going to be a rather substantial refactor of the Table code. Be patient...
Based on the concepts outlined in #339 .
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.