Open
Conversation
Author
|
I'm currently thinking that I would like to hold this PR until after I have created a maintenance branch for Python2-compatible vobject, and then apply it to the master branch. That branch will be the target for all new feature-development work, and I kinda view this a good candidate for that. The one possible stumbling block would be if someone (@AdamStursa?) needs this in a Python 2.x codebase. If that's the case, please speak up! |
|
Your plan is fine by me |
Author
|
@AdamStursa, would you be able to rebase this off current master branch? The big change will be to the tests, I think. I suggest that we make a separate file for the JCard tests, and inline the example JSON in that file (most of the others will be similar if you need an example). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR skarim#183