Draft
Conversation
eigenbrot
reviewed
Jan 27, 2026
| indexName: indexName, | ||
| searchClient: searchClient | ||
| // Add back once attributes confirmed: | ||
| // searchParameters: { restrictSearchableAttributes: ['title','hierarchy.lvl0','hierarchy.lvl1','content'] } |
There was a problem hiding this comment.
Do these attributes still need confirmation?
Comment on lines
+81
to
+82
| if (lower.includes('python-package-guide/tutorials/')) return 'Tutorial'; | ||
| if (lower.includes('/lessons/')) return 'Tutorial'; |
There was a problem hiding this comment.
Suggested change
| if (lower.includes('python-package-guide/tutorials/')) return 'Tutorial'; | |
| if (lower.includes('/lessons/')) return 'Tutorial'; | |
| if (lower.includes('python-package-guide/tutorials/') || lower.includes('/lessons/')) return 'Tutorial'; |
To be like the other "multi-source" tags?
| // searchParameters: { restrictSearchableAttributes: ['title','hierarchy.lvl0','hierarchy.lvl1','content'] } | ||
| }); | ||
|
|
||
| function hl(hit, path) { |
There was a problem hiding this comment.
Does "hl" stand for "highlight"? Apologies if this is overly pedantic, but all of the other functions have great descriptive names. This function seems like an outlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will close #649 when we implement it.