Allow for possibility to end with full NWP weight at end of blending#536
Open
RubenImhoff wants to merge 3 commits intomasterfrom
Open
Allow for possibility to end with full NWP weight at end of blending#536RubenImhoff wants to merge 3 commits intomasterfrom
RubenImhoff wants to merge 3 commits intomasterfrom
Conversation
Contributor
Author
Contributor
Author
|
Tests fail on the T-dating functionality, for some reason, but locally all tests do succeed. I am not sure why.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR fixes #481.
I have added a first, draft, approach to move to full NWP weights at the end of
timesteps, if requested by the user. The method adds an additional input parameter for thesteps.blending.forecastfunction:timestep_start_full_nwp_weight: int, optional:The timestep, which should be smaller than timesteps, at which a linear
transition takes place from the calculated weights to full NWP weight
(and zero extrapolation and noise weight) to ensure the blending
procedure becomes equal to the NWP forecast(s) at the last timestep
of the blending procedure. If not provided, the blending stick to the
theoretical weights provided by the chosen weights_method for a given
lead time and skill of each blending component.
If a value is set for
timestep_start_full_nwp_weight, the blending weights will linearly move from the weights at timesteptimestep_start_full_nwp_weightto full weight (1.0) for the NWP component and zero (0.0) weight for the extrapolation and noise cascade components at the final timestep of the blending procedure.I have given it a first test with the gallery example data from Australia. We only have three hours of NWP sample data here, so
timestep_start_full_nwp_weightis set at 12 (2 hour lead time) andtimestepsis set at 18 (3 hours in total).Testing this with the BPS weights, give the following weights with (a) indicating the current setup and (b) indicating the setup where

timestep_start_full_nwp_weightis applied:The forecast will then change from:

[original]
to:

[adjusted]