fix: Update text after settings decimals in SliderLabel#323
Merged
tlambert03 merged 10 commits intopyapp-kit:mainfrom Jan 27, 2026
Merged
fix: Update text after settings decimals in SliderLabel#323tlambert03 merged 10 commits intopyapp-kit:mainfrom
tlambert03 merged 10 commits intopyapp-kit:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
=======================================
Coverage 86.40% 86.40%
=======================================
Files 49 49
Lines 3861 3861
=======================================
Hits 3336 3336
Misses 525 525 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Czaki
approved these changes
Jan 27, 2026
Contributor
Czaki
left a comment
There was a problem hiding this comment.
For me, this PR looks good
Member
|
thanks for confirming @Czaki 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x-ref napari/napari#8534
Starting from commit 55b6639, it seems there was a disconnection in updating text.
I added a test to demonstrate the issue, which fails on main but passes with this PR
Again, like in #320, I'm not sure this is the correct fix, but my idea was this:
make
setDecimalscallupdateText, so that also in the__init__ofSliderLabelthe text gets forced to render properly, rather than justsetText. But maybe there are other events or some bigger event that should be callingupdateText? I didn't want to putupdateTextin the init for this reason, because then it would duplicate, but maybe there are other instances.Now,
setDecimalswill properly update the display of the text -- which before was both uncentered and the wrong decimalsBelow should be 0 decimals, but on main is not:
With this PR:
p.s. I tried to learn
git rebasefor these commit and seemingly screwed up 🙃