fix: Use faint color for disabled on-state toggle switch#325
Merged
tlambert03 merged 1 commit intopyapp-kit:mainfrom Feb 3, 2026
Merged
fix: Use faint color for disabled on-state toggle switch#325tlambert03 merged 1 commit intopyapp-kit:mainfrom
tlambert03 merged 1 commit intopyapp-kit:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 86.35% 86.37% +0.02%
==========================================
Files 49 49
Lines 3862 3868 +6
==========================================
+ Hits 3335 3341 +6
Misses 527 527 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation, we use the same toggle swtich groove color for enabled+off, disabled+on and disabled+off. This makes the check state unclear when the widget is disabled.
In this PR, on-color and off-color are mixed so it is visually easier to find the on-state switches, and they do not stand out too much.
Examples of enabled vs disabled toggle switches: