Use PyString::from_fmt to avoid intermediate String allocations #14248
+125
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `format!` + String with `PyString::from_fmt` + `format_args!` in __repr__ methods and one PyString::new call, writing directly to a Python string buffer (1 alloc) instead of going through format!() -> String -> PyString (2 allocs + copy). This optimization is only effective on Python 3.14+. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
format!+ String withPyString::from_fmt+format_args!in repr methods and one PyString::new call, writing directly to a Python string buffer (1 alloc) instead of going through format!() -> String -> PyString (2 allocs + copy). This optimization is only effective on Python 3.14+.