Draft
Conversation
Deploying logfire-docs with
|
| Latest commit: |
13ad61b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://032d0229.logfire-docs.pages.dev |
| Branch Preview URL: | https://try-prompt-toolkit.logfire-docs.pages.dev |
Member
samuelcolvin
left a comment
samuelcolvin
left a comment
There was a problem hiding this comment.
This is already a improvement on what we have now.
But I've pushed a demo of what I'd like, feel free to delete my commit, and maybe that has to wait for logfire init, but we do need to improve the API response to include default org and org created date, or at least created order.
| "typing-extensions >= 4.1.0", | ||
| "tomli >= 2.0.1; python_version < '3.11'", | ||
| "executing >= 2.0.1", | ||
| "prompt-toolkit >= 3.0.52", |
| f'Please select one of the following projects by number:\n{project_choices_str}\n', | ||
| choices=list(project_choices.keys()), | ||
| default='1', | ||
| org_options = sorted({project['organization_name'] for project in projects}) |
Member
There was a problem hiding this comment.
we shouldn't ask this if there's only one org.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to decide a bit of UX.