-
Notifications
You must be signed in to change notification settings - Fork 207
Add managed variables #1691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add managed variables #1691
Changes from 24 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
daa4da5
Add managed variables
dmontagu 871f113
Add on-change callbacks
dmontagu 4e299ed
More improvements
dmontagu 4c16ad7
Minor docs tweak
dmontagu cab12e4
fix failing tests, hopefully
dmontagu 082d0bb
Add tests for managed variables coverage gaps
dmontagu 7f20a68
Fix threading issue in deserialization cache
dmontagu 0fe82fa
Add tests for remaining coverage gaps in var() and is_resolve_function
dmontagu c82374b
Update logfire/variables/remote.py
dmontagu ab7dfee
Add configurable HTTP timeout for remote variables and bounded shutdown
dmontagu a5048ee
Fix remaining time calculation
dmontagu 39535fe
Rework implementation
dmontagu a99b490
Try to fix coverage
dmontagu d420f3b
Address TODO comment to support LabelRef's
dmontagu 7fddbfb
Fix failing test
dmontagu 1d563cb
Remove enabled field, add code_default ref support, make LabelRef.ver…
dmontagu b9dd937
Update managed-variables docs for LabelRef changes
dmontagu c69205e
Remove on_change/on_change_callbacks feature
dmontagu 7ef8a0b
Merge branch 'main' into managed-variables
dmontagu 4ea00cf
Address review feedback from Copilot and Devin on PR #1691
dmontagu f3cb969
Fix type_checking test to use valid variable name
dmontagu 9511231
Fix coverage gaps in variables module
dmontagu c451cf5
Address review feedback on variables PR
dmontagu 1c53f99
Address review feedback: fix VariablesConfig runtime import, remove v…
dmontagu ff83ea6
Fix coverage
dmontagu 410da24
Refactor variables config API and add lazy provider initialization
dmontagu 215e7ee
Add label compatibility checking to push_variable_types
dmontagu 042c0a2
Document public/private variables and API key scopes
dmontagu 36c5ea7
Update public/private variables docs to mention UI toggle
dmontagu d1e0dd4
Rename public/private → external/internal in managed variables docs
dmontagu 72a1a63
Add client-side feature flags with OFREP how-to guide
dmontagu 5d82df5
Merge branch 'main' into managed-variables
dmontagu a641ca7
Try getting tests to pass
dmontagu a2fb39b
Address PR review feedback and split managed variables docs
dmontagu 1447c7c
Add tests for 100% coverage of managed variables code
dmontagu b031205
Cover remaining branch partials in abstract.py
dmontagu 16f8fe3
Address PR review feedback: rollout fallback, timeouts, deserialization
dmontagu 36ca03a
Fix resolve_value docstring and widen exception handling in remote wr…
dmontagu 9e4f448
Merge branch 'main' into managed-variables
dmontagu 8da70b5
Update some docs screenshots
dmontagu e925946
Remove custom VariableProvider from public configure() API
dmontagu 1dee17f
Move external variables and OFREP docs to dedicated page
dmontagu 97b4abb
Move api_key from VariablesOptions to logfire.configure() kwarg
dmontagu d3b19c6
Fix docs: rollout labels don't support 'latest' as a direct key
dmontagu 43cf0bc
Fix get_serialized_value_for_label not blocking for first fetch + OFR…
dmontagu e825ad1
Fix coverage
dmontagu deb4842
Add test for get_serialized_value_for_label with block_before_first_r…
dmontagu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.