Fix some build warnings and mistakes in pyproject.toml#477
Merged
rdbisme merged 4 commits intopydata:masterfrom May 12, 2025
Merged
Fix some build warnings and mistakes in pyproject.toml#477rdbisme merged 4 commits intopydata:masterfrom
rdbisme merged 4 commits intopydata:masterfrom
Conversation
The warnings were:
```
warning: no files found matching 'tox.ini'
Running command Preparing metadata (pyproject.toml)
/tmp/pip-build-env-ua_ysm8p/overlay/lib/python3.12/site-packages/setuptools/dist.py:761: SetuptoolsDeprecationWarning: License classifiers are deprecated.
!!
********************************************************************************
Please consider removing the following classifiers in favor of a SPDX license expression:
License :: OSI Approved :: BSD License
See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
********************************************************************************
```
This hasn't been necessary in a long time. `setuptools` takes care of building a wheel, and whatever dependency it may need for that.
This is a clear bug, `setuptools` only accepts having a `build-requires` section but no `build-backend` key either accidentally or for historical reasons, and will stop doing so at some point.
rgommers
changed the title
rdbisme
reviewed
May 11, 2025
Collaborator
|
Ok for me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some build warnings that were visible in CI logs, as well as two mistakes in
pyproject.toml. In addition it would be good to start using the[project]section ofpyproject.toml(becausesetuptoolsis discouraging/deprecation/removing alternatives, see here), but that's more involved so left for another PR.The warnings were:
pyproject.tomlchanges:wheelas a build dependency. This hasn't been necessary in a long time.setuptoolstakes care of building a wheel, and whatever dependency it may need for that.build-backendkey. This is a clear bug,setuptoolsonly accepts having abuild-requiressection but nobuild-backendkey either accidentally or for historical reasons, and will stop doing so at some point.