Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
example_new_line.pdf
example_new_word.pdf
example_old.pdf
example.pdf
I discovered that the font-replacement code was not working, likely due to changes in the behavior of
page.clean_contents()in PyMuPDF. To address this issue, I made several modifications to the file to restore functionality.In the previous version, the logic resized the font to preserve the bounding box (bbox) of a line of text. However, I believe it is more appropriate to preserve the bbox of individual words to maintain the correct font size. Consequently, I changed the logic to preserve word bboxes.
I have attached the following files for reference:
Thank you for your time and consideration. Please let me know if you have any questions or need further information.