Skip to content

Fix FutureWarning raised in scipy.sparse.diags#524

Merged
ffl096 merged 1 commit intomainfrom
frantzen/diags-future-warning
Jan 16, 2026
Merged

Fix FutureWarning raised in scipy.sparse.diags#524
ffl096 merged 1 commit intomainfrom
frantzen/diags-future-warning

Conversation

@ffl096
Copy link
Member

@ffl096 ffl096 commented Jan 16, 2026

No description provided.

@ffl096 ffl096 added this to the 0.3.0 milestone Jan 16, 2026
@ffl096 ffl096 requested a review from Copilot January 16, 2026 08:23
@ffl096 ffl096 self-assigned this Jan 16, 2026
@ffl096 ffl096 added the bug Something isn't working label Jan 16, 2026
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.39%. Comparing base (6d3a103) to head (cea5a18).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
toponetx/utils/normalization.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #524   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files          45       45           
  Lines        4285     4285           
=======================================
  Hits         4045     4045           
  Misses        240      240           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes FutureWarning raised by scipy.sparse.diags by explicitly adding the dtype=None parameter to all calls in the normalization utilities. This warning was introduced in newer versions of scipy where the dtype parameter is becoming mandatory.

Changes:

  • Added dtype=None parameter to all 7 scipy.sparse.diags() calls in toponetx/utils/normalization.py

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ffl096 ffl096 merged commit 5061329 into main Jan 16, 2026
22 of 23 checks passed
@ffl096 ffl096 deleted the frantzen/diags-future-warning branch January 16, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant