[WIP] Prefix all fixtures with "django_"#711
Draft
blueyed wants to merge 4 commits intopytest-dev:mainfrom
Draft
[WIP] Prefix all fixtures with "django_"#711blueyed wants to merge 4 commits intopytest-dev:mainfrom
blueyed wants to merge 4 commits intopytest-dev:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
==========================================
+ Coverage 98.03% 98.04% +<.01%
==========================================
Files 32 32
Lines 1831 1839 +8
Branches 142 142
==========================================
+ Hits 1795 1803 +8
Misses 23 23
Partials 13 13
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
==========================================
- Coverage 98% 97.91% -0.09%
==========================================
Files 32 32
Lines 1853 1873 +20
Branches 147 147
==========================================
+ Hits 1816 1834 +18
- Misses 24 26 +2
Partials 13 13
Continue to review full report at Codecov.
|
blueyed
commented
Mar 16, 2019
pytest_django/plugin.py
Outdated
| live_server = django_live_server | ||
| rf = django_rf | ||
| settings = django_settings | ||
| transactional_db = django_transactional_db |
Contributor
Author
There was a problem hiding this comment.
This is problematic for x in request.funcargnames checks being used.. :/
Contributor
Author
|
Updated docs, and started to use new fixtures only internally, but it is quite messy. What also should be considered is using prefixes with the option names.. |
Not meant to be released necessarily, but to test it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
As for deprecation warnings, I think this is not really needed (now), but asked about it in pytest-dev/pytest#4900 (comment) already.