Force ordering of settings and transactional_db fixtures #870#871
Open
bdauvergne wants to merge 1 commit intopytest-dev:mainfrom
Open
Force ordering of settings and transactional_db fixtures #870#871bdauvergne wants to merge 1 commit intopytest-dev:mainfrom
bdauvergne wants to merge 1 commit intopytest-dev:mainfrom
Conversation
bluetech
reviewed
Apr 11, 2021
Member
bluetech
left a comment
bluetech
left a comment
There was a problem hiding this comment.
Thanks for the PR, I understand the issue now, and the change LGTM.
I suggested a comment, and this also needs a rebase against the latest master. Afterwards, if the CI is green, we can merge.
| """A Django settings object which restores changes after the testrun""" | ||
| skip_if_no_django() | ||
|
|
||
| if 'transactional_db' in request.fixturenames: |
Member
There was a problem hiding this comment.
I suggest adding a comment explaining the rationale:
Suggested change
| if 'transactional_db' in request.fixturenames: | |
| # Order the `settings` fixture after DB. | |
| # We don't want overridden settings to be in effect during | |
| # DB setup/teardown/post_migrate. | |
| if 'transactional_db' in request.fixturenames: |
Author
|
Tests failures seem to be the same than on master, with djmain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #870.