Fix false positive linter warning and a use before assignment#803
Open
CarstenGrohmann wants to merge 2 commits intopytest-dev:mainfrom
Open
Fix false positive linter warning and a use before assignment#803CarstenGrohmann wants to merge 2 commits intopytest-dev:mainfrom
CarstenGrohmann wants to merge 2 commits intopytest-dev:mainfrom
Conversation
Change logic to prevent:
testinfra/modules/socket.py:347:26: E0606: Possibly using variable 'protocol' before assignment (possibly-used-before-assignment)
CarstenGrohmann
force-pushed
the
20250401_fix_false_positive_linter_warnings
branch
from
6095c39 to
e8fb304
Compare
The hostname variable will not set for all connections/backends. Currently the test does not fail as not all backends are tested.
CarstenGrohmann
force-pushed
the
20250401_fix_false_positive_linter_warnings
branch
from
e8fb304 to
9acf605
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use before assignment is in the
hostfixture and will not affect the daily usage.