Add Provides-extra to uploaded metadata #7111
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neersighted
force-pushed
the
uploader-provides-extra
branch
from
00df5e4 to
5cc6d23
Compare
radoering
reviewed
Jan 15, 2023
Member
radoering
left a comment
radoering
left a comment
There was a problem hiding this comment.
Can we add a test in test_uploader? Something like
def test_uploader(uploader: Uploader, fixture_dir: FixtureDirGetter) -> None:
post_data = uploader.post_data(fixture_dir("distributions") / "demo-0.1.0-py2.py3-none-any.whl")
assert post_data == ...
for instance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: long-standing TODO comment
- [ ] Updated documentation for changed code.No changes needed