This repository was archived by the owner on Nov 2, 2022. It is now read-only.
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 66.55% 69.88% +3.32%
==========================================
Files 11 12 +1
Lines 311 425 +114
Branches 28 49 +21
==========================================
+ Hits 207 297 +90
- Misses 101 115 +14
- Partials 3 13 +10
|
Author
|
As a first draft, this is basically done. Let me know if there is anything else that I should add, or something that needs clarification or discussing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a prototype implementation of #20. Notable additions and changes include:
ExceptionGroupis "Generic" and can be specialised by exceptions. This allows catching specific groups, e.g.except ExceptionGroup[KeyError, TypeError] as exc_group:.ExceptionGroup[A, B, C]andissubclass(exc_group, ExceptionGroup[ABC]).ExceptionGroupattributes.exceptionsand.sourcesare tuples instead of lists. This is intended to prevent inconsistencies between the type and its attributes.This PR does not change:
ExceptionGrouphaving.message,.exceptionsand.sourcesattributes.except ExceptionGroup:catching all possibleExceptionGroups.