fix command just recv 8K#717
Closed
yyfyfyang wants to merge 1 commit intopython-zk:masterfrom
yyfyfyang:master
Closed
fix command just recv 8K#717yyfyfyang wants to merge 1 commit intopython-zk:masterfrom yyfyfyang:master
yyfyfyang wants to merge 1 commit intopython-zk:masterfrom
yyfyfyang:master
Conversation
Member
|
Hmm, the description of the problem makes sense, I haven't dug into lower level networking code in a while, so not sure if this is the best way to solve or if this should be fixed through an OS-level config, or if 8k is python's default regardless of the OS setting... Regardless, now that #716 landed, can you rebase this to see what CI thinks? |
ceache
requested changes
Feb 6, 2024
| result = b"" | ||
| temp = sock.recv(8192) | ||
| while temp: | ||
| result += temp |
Contributor
There was a problem hiding this comment.
This code loops forever as you never update temp in the loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Why is this needed?
sock.recv(8192)
recv byte 8K, Can not be modified，there will be data loss