feat: add support for parsing general-format numbers as decimals#133
Open
fabianskier wants to merge 1 commit intopythonicrubyist:masterfrom
Open
feat: add support for parsing general-format numbers as decimals#133fabianskier wants to merge 1 commit intopythonicrubyist:masterfrom
fabianskier wants to merge 1 commit intopythonicrubyist:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for automatic parsing of Excel cells with General number format into numeric values
(e.g., "1E-3" becomes 0.001). This is controlled via the newparse_general_as_numberoption in Creek::Book.Key changes
parse_general_as_numberoption to Creek::Book and Sheet.BigDecimal.Motivation
Without this change, numeric values formatted as General are returned as raw strings, which can lead to incorrect parsing or extra manual conversion. This feature improves developer ergonomics and data consistency.
Related issue
Fixes #96